Align with changes in latest ORM (unreleased) #1644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hibernate-reactive-core/src/main/java/org/hibernate/reactive/engine/ReactiveActionQueue.java
Fixed
Show fixed
Hide fixed
Comment on lines
+1046
to
+1049
| actionDelegate.getSession() | ||
| .getFactory() | ||
| .getMetamodel() | ||
| .entityPersister( action.getEntityName() ) | ||
| .entityPersister( actionDelegate.getEntityName() ) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| import org.hibernate.event.spi.EventSource; | ||
| import org.hibernate.reactive.engine.ReactiveExecutable; | ||
|
|
||
| public final class ReactiveEntityInsertActionHolder implements Executable, ReactiveExecutable, ComparableExecutable, |
Check warning
Code scanning / CodeQL
Inconsistent compareTo
|
Looks like exactly the same as #1636 , except some further gradle build script changes? |
Sanne
approved these changes
May 31, 2023
|
Yeah, sorry, I've added you as a reviewer but it was meant more as a FYI |
|
np, but if it's only additional commits you could have pushed them on the existing PR. |
|
This PR should work once we have the next 6.2 nightly build (I've tested it locally). |
I don't why, but without it, these tests can stop with a timeout exception. It happens to me wiht MySQL when I test the build with all databases and to Barry when testing MSSQL and JUnit 5. I will review this later
|
Replaced by #1647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Hibernte ORM 6.4.2-SNAPSHOT
Note that until the final version is released, Hibernate Reactive will use the snapshot available from Sonatype.
It will be released tomorrow, so it should not cause too much trouble.
Remember to update the gradle.properties file accordingly if you want to test local changes with ORM.
Superseeds #1636
Fix #1645